Accepting the endpoint owner as a uid in addition to their username - #967
Open
ldav1s wants to merge 1 commit into
Open
Accepting the endpoint owner as a uid in addition to their username#967ldav1s wants to merge 1 commit into
ldav1s wants to merge 1 commit into
Conversation
| if arbiter.endpoint_owner_mode: | ||
| cmd_uid = options.get('uid', None) | ||
| if cmd_uid != arbiter.endpoint_owner: | ||
| if cmd_uid not in arbiter.endpoint_owner_ids: |
Contributor
There was a problem hiding this comment.
I think we should have two options, one for the uid and one for the username. Mixing both is confusing.
Author
|
I'm OK with that. Unfortunately, the option that now only takes usernames is currently called 'uid', IIRC. |
Contributor
|
Yes indeed. However I think we could treat that as a bug and introduce the change. A warning if we get a uid would be awesome though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can get the username, but only getting the uid is much easier. The controller already gets the uid in endpoint owner mode, it just doesn't store it away.