Skip to content

Add windows-curses dependency for Windows - #1134

Open
biozz wants to merge 1 commit into
circus-tent:masterfrom
biozz:f/1100_add_windows_curses
Open

Add windows-curses dependency for Windows#1134
biozz wants to merge 1 commit into
circus-tent:masterfrom
biozz:f/1100_add_windows_curses

Conversation

@biozz

@biozz biozz commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

Closes #1100.

Disclaimer: I am using macOS and have difficulties setting up Windows environment to test this feature, so I would like to have some feedback from Windows users out there, pinging @ltalirz.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 63.875% when pulling 363e667 on biozz:f/1100_add_windows_curses into 2bedab0 on circus-tent:master.

@ltalirz

ltalirz commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

@biozz Thanks for this - I don't use windows regularly either, and even if I did I think the best solution is to include a basic windows test in the CI.

In order to achieve this, I would suggest to:

  • move the CI from travis to github actions
  • add a test run on a windows runner, at least for one python version (also put one in for Macos, while we're at it)

I've had a look at the travis config of circus and it looks rather minimal.
I'll have a quick go at a PR for 20 minutes - would you be happy to continue in case it turns out to take more effort?

@biozz

biozz commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

@ltalirz yes, sure thing. I was also checking out travis docs and it has multi-os support including windows.

Personally I don't have any preference on the ci as long as it works and not too complicated to setup. Tagging @k4nar for an opinion.

@ltalirz

ltalirz commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

I was also checking out travis docs and it has multi-os support including windows.

I see, wasn't even aware of that.
We've been using Github actions since a couple of months and have been pretty happy with it, especially in terms of speed.

20 minutes was a bit too optimistic but looks like I'm done. Will make a PR.

@k4nar

k4nar commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

I tried to add a Windows CI via AppVeyor a few years ago, without any success. If you manage to do it that would be awesome!

@ltalirz

ltalirz commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

If you manage to do it that would be awesome!

It's already done :-) However, the tests are still skipped on windows, i.e. it remains to be seen whether there are still tricks to be played. @biozz is kindly working on it

@biozz
biozz force-pushed the f/1100_add_windows_curses branch from 363e667 to 0ca6132 Compare August 12, 2020 06:13
@biozz
biozz force-pushed the f/1100_add_windows_curses branch from 0ca6132 to 3c67f16 Compare August 12, 2020 06:27
@biozz

biozz commented Aug 14, 2020

Copy link
Copy Markdown
Contributor Author

I am still trying to setup windows environment: virtualbox with windows server 2019 and things break where you don't expect. So that's why it takes quite a lot of time.

UPD: I couldn't get it to work, so for the time being this will have to wait for someone with windows experience to complete...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

curses not available on windows

4 participants