Respect use defaults#424
Open
s-nel wants to merge 2 commits intocirce:masterfrom
Open
Conversation
Author
|
@scala-steward @travisbrown sorry to ping you on this old PR, and I understand this project is pretty inactive, but any chance we could get this reviewed? We've been using my fork of circe-derivation in prod for a couple years and would love to switch to depending on an official release 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
useDefaultsparameter does nothing and defaults are always taken when the key is not present or isnullin the Json. This PR changes the behavior so that whenuseDefaultsisfalse, defaults are ignored, and an error will be raised for non-optional fields, orNonewill be used for optional fields.Fixes: #297