Add WithResultCallback option to avoid unbounded result accumulation#114
Merged
Add WithResultCallback option to avoid unbounded result accumulation#114
Conversation
rolinh
force-pushed
the
pr/rolinh/callback
branch
from
efa136d to
955b1f4
Compare
kaworu
reviewed
Apr 1, 2026
Member
kaworu
left a comment
kaworu
left a comment
There was a problem hiding this comment.
Thanks for the patch, I really like the direction. Some question about the implementation, nothing blocking.
Task results have always accumulated in memory until Drain is called, requiring callers to drain periodically to avoid unbounded growth. This change adds WithResultCallback, an option that processes each result as it completes, eliminating accumulation entirely. This change is backwards compatible. New and NewWithContext accept variadic Option arguments, so existing callers require no changes. Signed-off-by: Robin Hahling <code@hahling.ch>
Suggested-by: Alexandre Perrin <alex@isovalent.com> Signed-off-by: Robin Hahling <code@hahling.ch>
rolinh
force-pushed
the
pr/rolinh/callback
branch
from
955b1f4 to
f7b8f74
Compare
kaworu
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task results have always accumulated in memory until Drain is called, requiring callers to drain periodically to avoid unbounded growth. This change adds WithResultCallback, an option that processes each result as it completes, eliminating accumulation entirely.
This change is backwards compatible. New and NewWithContext accept variadic Option arguments, so existing callers require no changes.
Ref: #44 (comment)
Ref: #45