Conversation
…s Connector for v2 API - Fixed FireEyeETPManager.get_alert_details to extract from root dict when "data" wrapper is absent in v2 detail API responses. - Updated Alert datamodel to parse nested v2 schema including email-header, smtp-message, malware-detected, src, dst, and occurred/attack timestamps. - Added malware and recipient event generation and accurate severity-to-priority calculation. - Improved utils_manager to handle None timezone offsets and 14-digit compact timestamp parsing. - Updated connector timestamp filtering and safe alert sorting in create_alert_info. - Updated ontology mapping rules with v2 flattened event paths. - Replaced dict[str, Any] type annotations with SingleJson from TIPCommon.types. - Bumped integration version to 11.0 and updated release notes and uv.lock. - Added comprehensive unit tests for v2 payload extractions. BUG=b/543804375
|
❌ Integration Tests Failed Click to view the full report🧩 fire_eye_etp
❌ Failed Teststests/test_v2_parsing.py::test_sample_alerts_parsing |
|
❌ Integration Tests Failed Click to view the full report🧩 fire_eye_etp
❌ Failed Teststests/test_v2_parsing.py::test_sample_alerts_parsing |
|
❌ Integration Tests Failed Click to view the full report🧩 fire_eye_etp
❌ Failed Teststests/test_v2_parsing.py::test_sample_alerts_parsing |
Embed sample test alert payloads directly in test_v2_parsing.py to remove dependency on local temporary filesystem directory (/tmp), fixing the CI test integration failure. BUG=b/543804375
Use ruff: ignore instead of noqa comment for ANN401 in create_alert_info. BUG=b/543804375
Use rule name any-type instead of rule code ANN401 in suppression comment at line 165. BUG=b/543804375
Replace slash delimiters with underscores in ontology mapping raw_data match terms and use EnvironmentHandle in connector. BUG=b/543804375
KrishnaSharma06
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an issue where the FireEye ETP integration fails to ingest alert details and event data in the Email Alerts Connector when communicating with the v2 API (Bug b/543804375).
Key Changes
"data"wrapper is absent in v2 detail API responses.Alertmodel to parse nested v2 schema (alert,email-header,smtp-message,explanation/malware-detected,src,dst), generate malware and recipient events, and compute accurate numerical priorities.Noneand added support for 14-digit compact timestamp strings (YYYYMMDDhhmmss).create_alert_info.dict[str, Any]annotations withSingleJsonfromTIPCommon.types.11.0, updatedrelease_notes.yamlanduv.lock, and added unit tests for all 7 customer sample alert payloads.BUG=b/543804375