[Buganizer ID: 529765313] Azure Security Center: Make endpoint roots configurable for sovereign clouds - #1180
Open
patilgp-oss wants to merge 4 commits into
Open
[Buganizer ID: 529765313] Azure Security Center: Make endpoint roots configurable for sovereign clouds#1180patilgp-oss wants to merge 4 commits into
patilgp-oss wants to merge 4 commits into
Conversation
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
Error happened while executing a command: uv lock --check: Using CPython 3.11.16 interpreter at: /opt/hostedtoolcache/Python/3.11.16/x64/bin/python Resolved 57 packages in 386ms error: The lockfile at uv.lock needs to be updated, but --check was provided. hint: To update the lockfile, run uv lock. |
|
| - The default value of the 'Verify SSL' param in Azure Security Center - Security Alerts Connector must be a boolean true | |
| Actions with JSON results missing example files in resources/: GetOAuthRefreshToken, ListRegulatoryStandardControls, ListRegulatoryStandards | |
| 'azure_security_center' is missing tests/config.json |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
Error happened while executing a command: uv lock --check: Using CPython 3.11.16 interpreter at: /opt/hostedtoolcache/Python/3.11.16/x64/bin/python Resolved 57 packages in 229ms error: The lockfile at uv.lock needs to be updated, but --check was provided. hint: To update the lockfile, run uv lock. |
|
| - The default value of the 'Verify SSL' param in Azure Security Center - Security Alerts Connector must be a boolean true | |
| Actions with JSON results missing example files in resources/: GetOAuthRefreshToken, ListRegulatoryStandardControls, ListRegulatoryStandards | |
| 'azure_security_center' is missing tests/config.json |
- Added 'Login API Root', 'API Root', and 'Graph API Root' configuration parameters. - Replaced hardcoded Microsoft endpoints with configurable parameters across actions, connector, background job, and manager. - Added unit tests covering default and custom endpoints. - Bumped integration version to 18.0.
…nter - Updated Verify SSL default value in connector and definition YAML to true. - Standardized JsonResult example file names and paths in actions and resources. - Added GetOAuthRefreshToken JsonResult example. - Added tests/config.json configuration file. - Updated uv.lock for version 18.0. - Added type hints and docstrings in tests/test_manager.py.
patilgp-oss
force-pushed
the
fix-529765313-azure-security-center
branch
from
August 26, 2026 07:33
61b6b46 to
c41281a
Compare
- Wrapped long lines in ENDPOINTS dict in consts.py. - Fixed imports, type annotations, and ruff directives in tests/test_manager.py.
nitishgangal-ind
requested changes
Aug 30, 2026
nitishgangal-ind
left a comment
nitishgangal-ind
left a comment
There was a problem hiding this comment.
@patilgp-oss - Added few minor comments. Could you please take a look ? Thank you!
- Update verify_ssl fallback to True in RefreshTokenRenewalJob._build_manager_for_instance to align with definition.yaml default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What problem does this PR solve?
Resolves b/529765313: The Azure Security Center integration previously used hardcoded commercial Microsoft URLs (
login.microsoftonline.com,management.azure.com,graph.microsoft.com), preventing customers in Azure sovereign/government clouds (such as Azure US Government, Azure China) or behind enterprise forward proxy gateways from using the integration.How does this PR solve the problem?
definition.yaml, connector, actions, and job definitions:Login API Root(Default:https://login.microsoftonline.com)API Root(Default:https://management.azure.com)Graph API Root(Default:https://graph.microsoft.com)AzureSecurityCenterManager, action entrypoints, connector execution, and token renewal background job to dynamically calculate authentication scopes ({api_root}/.defaultand{graph_api_root}/.default) and construct endpoints dynamically.tests/test_manager.pycovering default endpoints, custom sovereign cloud endpoints, and token generation.18.0with updatedrelease_notes.yamlandpyproject.toml.Any other relevant information:
Checklist:
General Checks:
release_notes.yaml,definition.yaml).Open-Source Specific Checks:
For Google Team Members and Reviewers Only: