[ENH]: Allow cascading functions#7129
Merged
Merged
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tanujnay112
commented
May 26, 2026
| return globalDB.WithContext(ctx) | ||
| } | ||
|
|
||
| func TryGetDB(ctx context.Context) *gorm.DB { |
tanujnay112
commented
May 26, 2026
| return maxDepth, nil | ||
| } | ||
|
|
||
| func (g *attachedFunctionGraphState) incomingCollectionIDs(collectionID string) ([]string, error) { |
Contributor
Author
There was a problem hiding this comment.
make graph tests
HammadB
reviewed
May 26, 2026
| coordinator *Coordinator | ||
| ctx context.Context | ||
| databaseName string | ||
| incomingByOutput map[string][]*dbmodel.AttachedFunction |
Collaborator
There was a problem hiding this comment.
would be good to comment these fields
HammadB
reviewed
May 26, 2026
| return incoming, nil | ||
| } | ||
|
|
||
| incoming, err := g.coordinator.catalog.metaDomain.AttachedFunctionDb(g.ctx).GetAttachedFunctions(nil, nil, nil, &collectionID, nil, false) |
Collaborator
There was a problem hiding this comment.
is this an indexed lookup, is that a concern if not?
HammadB
reviewed
May 26, 2026
| return outgoing, nil | ||
| } | ||
|
|
||
| outgoing, err := g.coordinator.catalog.metaDomain.AttachedFunctionDb(g.ctx).GetAttachedFunctions(nil, nil, &collectionID, nil, nil, false) |
Collaborator
There was a problem hiding this comment.
is this an indexed lookup, is that a concern if not?
tanujnay112
commented
May 26, 2026
|
|
||
| // Rebuild the graph under locks before validating/inserting. | ||
| graphState, err = s.buildAttachFunctionGraph(txCtx, req.InputCollectionId, existingOutputCollectionID, req.Database) | ||
| if err != nil { |
Contributor
Author
There was a problem hiding this comment.
didnt detect that it changed??
HammadB
reviewed
May 26, 2026
| return err | ||
| } | ||
|
|
||
| // Rebuild the graph under locks before validating/inserting. |
Collaborator
There was a problem hiding this comment.
seems like we just lock and rebuild?
HammadB
reviewed
May 26, 2026
| } | ||
|
|
||
| // Check if input collection is being used as an output collection by any attached function | ||
| inputCollectionIDStr := req.InputCollectionId |
Collaborator
There was a problem hiding this comment.
would appreciate some commentary here
tanujnay112
commented
May 26, 2026
| functionIDs := make([]uuid.UUID, 0, len(attachedFunctionsUsingAsOutput)) | ||
| seenFunctionIDs := make(map[uuid.UUID]struct{}, len(attachedFunctionsUsingAsOutput)) | ||
| for _, attachedFunction := range attachedFunctionsUsingAsOutput { | ||
| if _, ok := seenFunctionIDs[attachedFunction.FunctionID]; ok { |
Contributor
Author
There was a problem hiding this comment.
more commenting in this block, it's a bit unreadable
HammadB
reviewed
May 26, 2026
| inputCollectionIDStr := req.InputCollectionId | ||
| attachedFunctionsUsingAsOutput, err := s.catalog.metaDomain.AttachedFunctionDb(txCtx).GetAttachedFunctions(nil, nil, nil, &inputCollectionIDStr, nil, false) | ||
| // Check if output collection already exists so we can materialize and then lock the full graph in a stable order. | ||
| existingOutputCollections, err := s.catalog.metaDomain.CollectionDb(txCtx).GetCollections(nil, &req.OutputCollectionName, req.TenantId, req.Database, nil, nil, false) |
tanujnay112
commented
May 26, 2026
| inputCollectionIDStr := req.InputCollectionId | ||
| attachedFunctionsUsingAsOutput, err := s.catalog.metaDomain.AttachedFunctionDb(txCtx).GetAttachedFunctions(nil, nil, nil, &inputCollectionIDStr, nil, false) | ||
| // Check if output collection already exists so we can materialize and then lock the full graph in a stable order. | ||
| existingOutputCollections, err := s.catalog.metaDomain.CollectionDb(txCtx).GetCollections(nil, &req.OutputCollectionName, req.TenantId, req.Database, nil, nil, false) |
Contributor
Author
There was a problem hiding this comment.
plurality is confusing
tanujnay112
commented
May 26, 2026
|
|
||
| outputTailDepth := 0 | ||
| if len(existingOutputCollections) > 0 { | ||
| outputTailDepth, err = graphState.collectionTailDepth(existingOutputCollectionID, map[string]int{}, map[string]struct{}{}) |
Contributor
Author
There was a problem hiding this comment.
should be in 547's if block
HammadB
reviewed
May 26, 2026
| } | ||
|
|
||
| outputTailDepth := 0 | ||
| if len(existingOutputCollections) > 0 { |
Collaborator
There was a problem hiding this comment.
seems like it can be collapes with reaches check block above
HammadB
approved these changes
May 26, 2026
tanujnay112
force-pushed
the
fn_on_output
branch
3 times, most recently
from
cd63962 to
f147dab
Compare
This comment has been minimized.
This comment has been minimized.
tanujnay112
force-pushed
the
fn_on_output
branch
2 times, most recently
from
2223dbb to
ea10072
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR allows "cascading" (chained) functions: attaching a function whose input collection is itself the output of another function. Previously this was unconditionally blocked. Now it's allowed only when every upstream function writing to that collection is async. Sync upstream functions still block the attachment.
Two additional safety checks are also introduced:
maxAttachedFunctionDepth = 5Improvements & Bug fixes
New functionality
Test plan
How are these changes tested?
test_task_api.py has been adjusted for ths PR. Tests have been added and adjusted in that file.
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the _docs section?_