[CHORE] Make foundation api /init use correct schema, index, dim#7127
Merged
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This comment has been minimized.
This comment has been minimized.
davedash
approved these changes
May 25, 2026
LLay
added a commit
that referenced
this pull request
May 26, 2026
Mirrors the CLI POC (chroma-core/foundation #97): after ensuring each source collection, /init attaches the server-side function via SysDb::create_attached_function, with the wiki collection as output. - Attachment name `{source}_to_wiki`; operator `http_generate` (configurable); params carry the modal `endpoint_url`, `source_collection`, and `source_kind`. - New FoundationConfig fields: function_name, function_endpoint_url, min_records_for_invocation (defaults mirror the POC + the chroma frontend's 100-record default). Output dimension is already hardcoded to 1024 in /init (chroma #7127), so no seed_output_collection step is needed. - Idempotent: AlreadyExists / CollectionAlreadyHasFunction are treated as success so /init stays safe to call repeatedly.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
initnow uses correct schema, index and dim based on foundation settings.Test plan
How are these changes tested?
Added tests for new basic items of schema/collection creation/planning. The hardcoding of 1024 dim is untested.
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
None needed
Observability plan
No addtl needed
Documentation Changes
None