[BUG]: WQS repairs on bootup#7126
Open
tanujnay112 wants to merge 1 commit into
Open
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
tanujnay112
force-pushed
the
repair_wqs
branch
2 times, most recently
from
5dfb5c1 to
e680d73
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tanujnay112
force-pushed
the
repair_wqs
branch
2 times, most recently
from
aef2bfc to
889d11d
Compare
HammadB
reviewed
May 26, 2026
| .results | ||
| .into_iter() | ||
| .map(|result| { | ||
| match InvocationStatus::try_from(result.status).unwrap_or(InvocationStatus::NotDone) |
Collaborator
There was a problem hiding this comment.
nit - move this in a tryFrom on the type like other protos to match our patterns
HammadB
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR renames
AreInvocationsDone(which returned[]bool) toCheckInvocationStatus(which returns a three-state enum). The key semantic change is that the old binary done/not-done is replaced with three states:NOT_DONE(0) — default, work still in progressDONE(1) — completed (soft/hard deleted, or offset advanced with no pending heap entry)NEEDS_REPAIR(2) — offset advanced butheap_entry_pending=true, meaning the WQS crashed mid-repairThe new
NEEDS_REPAIRstate enables the work queue manager to automatically repair stale entries on bootup, which is the core bug fix this PR addresses.In the proto we replaced the RPC for
AreInvocationsDonewith ``CheckInvocationStatus` this is not backwards compatible but that is fine as there is not production use for the former RPC yet.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the _docs section?_