[BUG](dispatcher): shut down IO runtime cleanly without async-context panic#7100
Open
rescrv wants to merge 1 commit into
Open
[BUG](dispatcher): shut down IO runtime cleanly without async-context panic#7100rescrv wants to merge 1 commit into
rescrv wants to merge 1 commit into
Conversation
… panic Change io_runtime from Arc<Runtime> to Option<Runtime> so the dispatcher owns the runtime exclusively and can shut it down on stop. The on_stop lifecycle method now takes the runtime and shuts it down with a 5-second timeout via spawn_blocking, avoiding the panic that occurs when dropping a Tokio runtime from within an async context. Add a Drop impl as a safety net that calls shutdown_background() for the non-blocking fallback path. When the runtime has already been taken (after stop or drop), incoming IO tasks are aborted with a metric. Co-authored-by: AI
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Change io_runtime from Arc to Option so the dispatcher
owns the runtime exclusively and can shut it down on stop. The on_stop
lifecycle method now takes the runtime and shuts it down with a 5-second
timeout via spawn_blocking, avoiding the panic that occurs when dropping
a Tokio runtime from within an async context.
Add a Drop impl as a safety net that calls shutdown_background() for
the non-blocking fallback path. When the runtime has already been taken
(after stop or drop), incoming IO tasks are aborted with a metric.
Test plan
CI
Migration plan
N/A
Observability plan
See prod not panic on shutdown. Ditto for test.
Documentation Changes
N/A
Co-authored-by: AI