chore(ingest): use builtin tuple, drop typing.Tuple, add docstring#7094
Open
oab24413gmai wants to merge 1 commit into
Open
chore(ingest): use builtin tuple, drop typing.Tuple, add docstring#7094oab24413gmai wants to merge 1 commit into
oab24413gmai wants to merge 1 commit into
Conversation
Replace typing.Tuple with builtin tuple (PEP 585) in parse_topic_name return annotation, and add a docstring to create_topic_name for consistency with parse_topic_name.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small modernization in
chromadb/ingest/impl/utils.py:from typing import Tupleand use the builtintuple[...]in theparse_topic_namereturn annotation (project already targets a Python version where this is supported).create_topic_namefor parity with its sibling.No behavior change.