[BUG] prevent integer overflow in HNSW index resize#7093
Closed
rescrv wants to merge 1 commit into
Closed
Conversation
Replace unchecked arithmetic (capacity * 2, len + additional) with a central required_hnsw_capacity function that uses checked_add, checked_mul, and checked_next_power_of_two, returning a typed HnswCapacityError::Overflow on overflow instead of silently wrapping. All six callsites in fast_writer, spann/types, distributed_hnsw, and local_hnsw now route through this function, which encodes two growth strategies (Double and NextPowerOfTwo) and an optional resize-at- capacity flag to preserve each callsite's existing semantics. Also constrain resize_factor to [1.0, 5.0] on the Rust HnswIndexConfig via a validate(range) annotation, with tests for both boundary rejection and overflow at usize::MAX. Co-authored-by: AI
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
Contributor
Author
|
In favor of #7098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Replace unchecked arithmetic (capacity * 2, len + additional) with a
central required_hnsw_capacity function that uses checked_add,
checked_mul, and checked_next_power_of_two, returning a typed
HnswCapacityError::Overflow on overflow instead of silently wrapping.
All six callsites in fast_writer, spann/types, distributed_hnsw, and
local_hnsw now route through this function, which encodes two growth
strategies (Double and NextPowerOfTwo) and an optional resize-at-
capacity flag to preserve each callsite's existing semantics.
Also constrain resize_factor to [1.0, 5.0] on the Rust
HnswIndexConfig via a validate(range) annotation, with tests for
both boundary rejection and overflow at usize::MAX.
Test plan
CI
Migration plan
N/A
Observability plan
N/A
Documentation Changes
N/A
Co-authored-by: AI