fix: enforce exact name match in get_collection#7084
Open
kailashv2 wants to merge 1 commit into
Open
Conversation
Fixes chroma-core#7063 get_collection() was returning a collection even when the requested name didn't exactly match. The sysdb query uses a prefix/partial match internally, so querying 'colls' would return 'coll' if it existed. Added an exact name check after fetching: if the returned collection's name doesn't match the requested name exactly, return NotFound instead.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7063
get_collection()was returning a collection even when the requestedname didn't exactly match. For example, querying
collswould returncollif it existed.Root Cause
The
sysdbquery uses a partial/prefix match internally. The frontendnever verified that the returned collection's name exactly matched the
requested name.
Fix
Added an exact name check after fetching from sysdb:
NotFounderrorTesting
collswhen onlycollexists now returns 404