feat: AmazonBedrockEmbeddingFunction support for Cohere Embed models#1675
feat: AmazonBedrockEmbeddingFunction support for Cohere Embed models#1675JGalego wants to merge 5 commits into
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Please also update the embedding model documentation: https://github.com/chroma-core/docs/blob/main/docs/embeddings.md Currently the |
There's an open PR from another contributor for the docs - chroma-core/docs#204 |
|
I've been waiting for the review for JS implementation as well #1659 |
…e models; Added input_type arg to CohereEF
|
@tazarov any other changes? |
|
Our underlying impl has changed and so this PR is not landable as is. That being said - we'd still like to add this functionality and that is now tracked in this issue. |
Description of changes
AmazonBedrockEmbeddingFunctionTest plan
How are these changes tested?
pytestfor pythonAlso, manually tested with python: