Skip to content

Fix flaky e2e tests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cholick merged 11 commits into from
Apr 18, 2026
Merged

Fix flaky e2e tests #6

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9536843
Bring back wait_for_message
cholick Apr 17, 2026
5c1784c
Increase wait_for_messages timeout to 5 seconds
cholick Apr 18, 2026
43a30bf
Debugging
cholick Apr 18, 2026
a0e5ac1
Probe message to ensure port ready before we invoke go
cholick Apr 18, 2026
b9cf9e5
Debugging
cholick Apr 18, 2026
5a5cc30
Debugging panic
cholick Apr 18, 2026
ec4762f
Comment out delay
cholick Apr 18, 2026
f3f930c
Only delay
cholick Apr 18, 2026
e78a5c5
Fix in the c++ code?
cholick Apr 18, 2026
344b52f
Cleanup
cholick Apr 18, 2026
9a2137c
Move tests back to running just once
cholick Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/midi/out.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"errors"
"fmt"
"strings"
"time"

"github.com/cholick/midi-cli/pkg/rtmidi"
"github.com/samber/lo"
Expand Down Expand Up @@ -163,6 +164,9 @@ func (o *out) Panic(channel int) error {
}

func (o *out) Close() {
// hammered at this a bit, but tests flaked without the sleep
// was never an issue on a faster machine, but worth leaving in
time.Sleep(100 * time.Millisecond)
_ = o.midiOut.Close()
}

Expand Down