Skip to content

feat: use request.app.url_for #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baseplate-admin merged 2 commits into from
Mar 11, 2026
Merged

feat: use request.app.url_for #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef91782
add
baseplate-admin Mar 11, 2026
d8be787
Merge branch 'main' into remove
baseplate-admin Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/backend/app/routes/http/reverse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from urllib.parse import quote

from botocore.exceptions import ClientError
from fastapi import APIRouter, Header, HTTPException, UploadFile, status, Request
from fastapi import APIRouter, Header, HTTPException, Request, UploadFile, status
from fastapi.responses import StreamingResponse
from sqlmodel import col, select
from types_aiobotocore_s3.type_defs import CompletedPartTypeDef
Expand All @@ -20,8 +20,8 @@
RoomOut,
)
from app.settings import settings
from app.states.room import RoomState
from app.states.app import UploadProgress
from app.states.room import RoomState
from app.tasks.clean_file import delete_expired_file
from app.tasks.persist_file import persist_file_record

Expand Down Expand Up @@ -86,7 +86,6 @@ async def add_host(
async def upload_file_to_room(
room_id: str,
file: UploadFile,
file: UploadFile,
request: Request,
s3: S3Dep,
x_host_token: str = Header(),
Expand Down Expand Up @@ -208,7 +207,7 @@ async def upload_file_to_room(
filename=filename,
size=uploaded_size,
uploaded_at=now,
download_url=f"{settings.ROOT_PATH}/download/{file_key}",
download_url=str(request.app.url_path_for("download_files", key=file_key)),
)

# Persist in room state + fan-out event via pub/sub (atomic append)
Expand Down