Skip to content

Add comprehensive testing suite and patch error handling gaps#101

Open
realcodywburns wants to merge 1 commit into
mainfrom
claude/identify-todos-testing-suite-O92AA
Open

Add comprehensive testing suite and patch error handling gaps#101
realcodywburns wants to merge 1 commit into
mainfrom
claude/identify-todos-testing-suite-O92AA

Conversation

@realcodywburns
Copy link
Copy Markdown
Contributor

  • Create shared test utilities (tests/helpers.ts) with mockLogger, mockProvider, createTestEngine, makeEvent, collectEvents
  • Patch 5 error handling gaps:
    • TaskGenerator/Judge: emit system:error on JSON parse failures instead of silent return
    • SystemSelector: emit system:error when LLM returns no tool selection
    • RecursiveImprover: fix listener leak by unregistering task:judged handler after firing
    • Engine: expose off() method for event handler cleanup
  • Add 15 new test files covering all previously untested modules:
    • Unit tests: config, hash, logger, provider, claude, local, migrations, entity-creation, task-generator, judge, system-selector, loader, ipc, runner, server
    • E2E tests: objective pipeline, ingest pipeline, web→SSE flow
  • Total: 182 tests passing (up from 93), 0 failures
  • Coverage: 25/27 source files tested (only pure type definition files excluded)

https://claude.ai/code/session_01HpeSnaPMx96u2ALyP57AC3

- Create shared test utilities (tests/helpers.ts) with mockLogger, mockProvider, createTestEngine, makeEvent, collectEvents
- Patch 5 error handling gaps:
  - TaskGenerator/Judge: emit system:error on JSON parse failures instead of silent return
  - SystemSelector: emit system:error when LLM returns no tool selection
  - RecursiveImprover: fix listener leak by unregistering task:judged handler after firing
  - Engine: expose off() method for event handler cleanup
- Add 15 new test files covering all previously untested modules:
  - Unit tests: config, hash, logger, provider, claude, local, migrations, entity-creation, task-generator, judge, system-selector, loader, ipc, runner, server
  - E2E tests: objective pipeline, ingest pipeline, web→SSE flow
- Total: 182 tests passing (up from 93), 0 failures
- Coverage: 25/27 source files tested (only pure type definition files excluded)

https://claude.ai/code/session_01HpeSnaPMx96u2ALyP57AC3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants