fix: SWD_Sequence stuck in spi mode when req bits less than 8

[kaidegit]

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of SPI read and write operations to avoid unnecessary actions when no full bytes are to be transferred, enhancing efficiency and correctness.

• Refactor

  • Streamlined control flow for SPI data transfer and removed redundant operations for better performance.

[coderabbitai]

Walkthrough

The SPI_SWD_Sequence function was updated to add conditional checks, ensuring SPI operations for the integer portion of data are only performed when there are bytes to transfer. Data bits are now explicitly set before processing, and redundant operations and GPIO writes were removed. Logging macros were introduced but left commented out.

Changes

File(s)	Change Summary
projects/HSLink-Pro/src/SW_DP/SW_DP_SPI.c	Added conditional checks for integer byte transfers, explicit data bits setting, minor cleanups

Poem

In bytes and bits, we hop with care,
Only sending what is truly there.
No more empty SPI commands sent,
Each transfer now is time well spent.
With cleaner code, we leap ahead—
Efficiency’s path is wisely tread!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

projects/HSLink-Pro/src/SW_DP/SW_DP_SPI.c (3)

21-22: Drop stale logging macros

The commented-out LOG_TAG and elog.h lines are dead code and add noise during future merges. Either wrap them in a compile-time logging switch (e.g. #ifdef SWD_DEBUG_LOG) or remove them altogether.

---

117-117: Remove in-line commented trace

// log_d("SWD_Sequence …") is likewise inert. Delete or wrap it in the same conditional logging block suggested above to keep the function lean.

---

147-155: Nit: set data width before burst length for symmetry

Pure style, but calling spi_set_data_bits() first makes the write path match the remainder-bit path and removes any future ambiguity about which setting is applied to the burst:

-            spi_set_write_data_count(SWD_SPI_BASE, integer_val);
-            spi_set_data_bits(SWD_SPI_BASE, 8);
+            spi_set_data_bits(SWD_SPI_BASE, 8);
+            spi_set_write_data_count(SWD_SPI_BASE, integer_val);

No functional difference today, but helps readability and guards against potential driver argument-validation changes.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac406b7 and 283997f.

📒 Files selected for processing (1)

• projects/HSLink-Pro/src/SW_DP/SW_DP_SPI.c (3 hunks)

🔇 Additional comments (1)

projects/HSLink-Pro/src/SW_DP/SW_DP_SPI.c (1)

120-133: Guard against integer-val == 0 looks good – double-check SWDIO idle level

The new if (integer_val) block elegantly avoids an unnecessary byte-wide transfer when fewer than 8 bits are requested – nice catch.

One point to verify: after the integer-byte read completes, SWDIO stays in input mode (gpio_write_pin(..., 0) only comes at the very end). Ensure this meets the electrical/timing spec for the whole function path (especially error branches).

[kaidegit]

@HalfSweet 看看？

[HalfSweet]

LGTM