use appbundler and habitat scan fixes#1951
Open
sanjain-progress wants to merge 1 commit into
Open
Conversation
Mirror chef/chef-cli#341 changes in Ohai (excluding dependency updates). - Simplify Habitat install script usage in Buildkite artifact test - Update habitat plans to use appbundler-generated binstubs and runtime wrapper - Remove vendored .github directories to reduce scanner false positives - Generalize lockfile cleanup and add binstub patch helper Signed-off-by: Sachin Jain <Sachin.jain@chef.io>
sanjain-progress
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the packaging and installation process for ohai in Habitat environments. The main changes include switching to appbundler for binstub generation, cleaning up vendored gems to avoid CVE false positives, and simplifying the Habitat install script.Changes Made
.expeditor/buildkite/artifact.habitat.test.ps1to simplify Habitat installation flow and remove extra debug output.habitat/plan.shto use appbundler-generated binstubs, runtime wrapper, and cleanup hooks.habitat/plan.ps1to remove vendored.githubdirectories to reduce scanner false positives.cleanup_lint_roller.rb.binstub_patch.rbto preserve runtime gem path behavior for binstubs.