fix(ios): retry startup diagnostics overlay when scene unavailable#3521
Open
shenhualxt901152 wants to merge 5 commits intochatboxai:mainfrom
Open
fix(ios): retry startup diagnostics overlay when scene unavailable#3521shenhualxt901152 wants to merge 5 commits intochatboxai:mainfrom
shenhualxt901152 wants to merge 5 commits intochatboxai:mainfrom
Conversation
added 5 commits
February 24, 2026 08:12
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- fix startup diagnostics overlay presentation to avoid getting stuck when no active UIWindowScene is available at timeout moment\n- only mark diagnostics as presented after overlay is actually shown\n- add pending-reason retry on app foreground/active lifecycle\n- keep logs copy/share overlay behavior\n\n## Verification\n- xcodebuild Release (iphoneos) build: PASS\n- xcodebuild Debug (iphonesimulator, iPhone 16 Pro 18.4) build: PASS\n- simctl install + launch on booted simulator: PASS\n- startup logs confirmed top container and diagnostics overlay presented\n- xcodebuild test: N/A (scheme App not configured for test action)\n