fix: release waitFor listeners on cancellation - #83
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling
actor.waitForleft its state listener registered. Later transitions still called the cancelled wait's predicate. A predicate defect during the subscription recheck leaked the listener too.Own listener registration with
Effect.acquireUseRelease. Keep the current-state fast path and post-subscription recheck. Release on success, defect, and cancellation. Public types and actor stop behavior stay unchanged;awaitFinalandsendAndWaitinherit the cleanup.Validation: both real-actor regressions fail before the fix. Full gate passes: 385 tests, 853 assertions, typecheck, lint, format, build, and all example gates. One independent Counsel review found no blocker. Includes a patch changeset.