Skip to content

fix: imports and usage of image_uploader #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FilipeR13 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: imports and usage of image_uploader #577

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb7a549
fix: imports and usage of image_uploader
FilipeR13 Apr 30, 2025
d4eeb7b
style: formatter
FilipeR13 Apr 30, 2025
9d2601d
fix: banner upload for departments
FilipeR13 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/atomic_web/components/image_uploader.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@ defmodule AtomicWeb.Components.ImageUploader do
<% end %>
</figure>
<%= for err <- upload_errors(@upload, entry) do %>
<p class="alert alert-danger">{Phoenix.Naming.humanize(err)}</p>
<p class="alert alert-danger text-red-500">{Phoenix.Naming.humanize(err)}</p>
<% end %>
</article>
<% end %>
<% end %>
<%= for err <- upload_errors(@upload) do %>
<p class="alert alert-danger">{Phoenix.Naming.humanize(err)}</p>
<p class="alert alert-danger text-red-500">{Phoenix.Naming.humanize(err)}</p>
<% end %>
</section>
</div>
Expand Down
3 changes: 1 addition & 2 deletions lib/atomic_web/live/activity_live/form_component.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ defmodule AtomicWeb.ActivityLive.FormComponent do
use AtomicWeb, :live_component

alias Atomic.Activities
alias AtomicWeb.Components.ImageUploader

import AtomicWeb.Components.Forms
import AtomicWeb.Components.{Forms, ImageUploader}

@impl true
def update(%{activity: activity} = assigns, socket) do
Expand Down
2 changes: 1 addition & 1 deletion lib/atomic_web/live/activity_live/form_component.html.heex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<div class="flex flex-col-reverse xl:flex-row">
<div class="w-full xl:w-1/3">
<.live_component module={ImageUploader} id="uploader" uploads={@uploads} target={@myself} />
<.image_uploader id="uploader" upload={@uploads} class="h-32 w-full border border-zinc-300 shadow-sm xl:h-64" image_class="h-32 w-full object-cover xl:h-64" />
</div>

<div class="flex flex-col">
Expand Down
3 changes: 1 addition & 2 deletions lib/atomic_web/live/announcement_live/form_component.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ defmodule AtomicWeb.AnnouncementLive.FormComponent do
use AtomicWeb, :live_component

alias Atomic.Organizations
alias AtomicWeb.Components.ImageUploader

import AtomicWeb.Components.Forms
import AtomicWeb.Components.{Forms, ImageUploader}

@impl true
def mount(socket) do
Expand Down
2 changes: 1 addition & 1 deletion lib/atomic_web/live/announcement_live/form_component.html.heex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<.field field={f[:description]} type="textarea" placeholder="Description" required class="h-44 w-full resize-none overflow-auto xl:h-64" />
</div>
<div class="space-y-4">
<.live_component module={ImageUploader} id="uploader" uploads={@uploads} target={@myself} class="object-cover" />
<.image_uploader id="uploader" upload={@uploads.image} class="aspect-square w-full border border-zinc-300 shadow-sm" />

<div class="flex justify-end">
<.button size={:md} color={:white} icon="hero-cube" type="submit">{gettext("Save Changes")}</.button>
Expand Down
5 changes: 2 additions & 3 deletions lib/atomic_web/live/department_live/form_component.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ defmodule AtomicWeb.DepartmentLive.FormComponent do
use AtomicWeb, :live_component

alias Atomic.Departments
alias AtomicWeb.Components.ImageUploader

import AtomicWeb.Components.Forms
import AtomicWeb.Components.{Forms, ImageUploader}

@impl true
def render(assigns) do
Expand All @@ -24,7 +23,7 @@ defmodule AtomicWeb.DepartmentLive.FormComponent do
<p class="atomic-form-help-text pb-4">{gettext("The banner of the department (2055×256px for best display)")}</p>
</div>
<div>
<.live_component module={ImageUploader} id="uploader" uploads={@uploads} target={@myself} />
<.image_uploader id="uploader" upload={@uploads.image} class="h-32 w-full border border-zinc-300 shadow-sm xl:h-64" image_class="h-32 w-full object-cover xl:h-64" />
</div>
</div>

Expand Down
5 changes: 2 additions & 3 deletions lib/atomic_web/live/partner_live/form_component.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ defmodule AtomicWeb.PartnerLive.FormComponent do
use AtomicWeb, :live_component

alias Atomic.Partners
alias AtomicWeb.Components.ImageUploader
import AtomicWeb.Components.Forms
import AtomicWeb.Components.{Forms, ImageUploader}

@impl true
def render(assigns) do
Expand Down Expand Up @@ -38,7 +37,7 @@ defmodule AtomicWeb.PartnerLive.FormComponent do
<p class="atomic-form-help-text pb-4">{gettext("The image of the partner (960x960px for best display)")}</p>
</div>
<div>
<.live_component module={ImageUploader} id="uploader" uploads={@uploads} target={@myself} />
<.image_uploader id="uploader" upload={@uploads.image} class="h-32 w-full border border-zinc-300 shadow-sm xl:h-64" image_class="h-32 object-cover xl:h-64" />
</div>
</div>
<h2 class="mt-8 mb-2 w-full border-b pb-2 text-lg font-semibold text-zinc-900">{gettext("Internal")}</h2>
Expand Down
Loading