Remove SetCertificateRequestConditionError

[inteon]

Instead of returning SetCertificateRequestConditionError, we now have 3 return values for the sign function. we now return a SignResult value.

Using the WithExtraConditions option, we can set the custom conditions on a CertificateRequest/ CertificateSigningRequest resource.

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wallrj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SgtCoDFish]

Got a few comments on this one - I see what you're aiming for.

On a broader note, while I recognise we're v0 with issuer-lib it definitely feels harder to stomach breaking changes in this repo now. There are multiple issuers working today which import this lib: https://pkg.go.dev/github.com/cert-manager/issuer-lib@v0.9.0/controllers?tab=importedby

The dev UX of us making a breaking change really blows, even if we've warned people that it could happen. If we changed the import path (by pushing a new major version for every breaking change) it'd be a lot less painful for downstream consumers.

I'd be supportive of marking issuer-lib as v1 without making any breaking changes, and then immediately working on v2 which could include breaking changes. I don't think that hurts anyone!

[maelvls]

we're v0 with issuer-lib it definitely feels harder to stomach breaking changes in this repo now. There are multiple issuers working today which import this lib: https://pkg.go.dev/github.com/cert-manager/issuer-lib@v0.9.0/controllers?tab=importedby

I totally agree with Ash. Pre-v1 projects are just too much of a pain, and there is no reason to cause that pain, especially since it would cost almost no effort to cut a v1 now.

Regardless of whether the project is v1 material or not, let's avoid needlessly causing pain. Cloudflare folks will thank us.

Note that lots of people are developing custom issuers behind closed curtains. We probably only see 1% of the users of this project.

[maelvls]

could you add a code snippet showing how an implementor would use this? that would greatly help me see how it's meant to be used

[inteon]

I added this to our example issuer: 19dd427