Remove GetIssuerTypeIdentifier from Issuer API#186
Remove GetIssuerTypeIdentifier from Issuer API#186inteon wants to merge 2 commits intocert-manager:mainfrom
Conversation
1a1ecef to
86ed14d
Compare
|
I don't have the right commit bits to move this along, but I'm a fan of simplifying the interface. Would it be feasible to remove |
…s in our example Signed-off-by: Tim Ramlot <[email protected]>
…roller initialisation Signed-off-by: Tim Ramlot <[email protected]>
86ed14d to
89d6670
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
It is now moved to the controller initialization.
Instead having to implement
GetIssuerTypeIdentifierfor each issuer type, we now just ask to provide theGroupResourcewhen intialising the controller. This makes the API more intuitive.Later (future PRs), we could use kubernetes discovery to discover the
GroupResourcebased on the installed CRDs.