enriching: added run_numbers field for the cms datasets (#3752)#3752
Open
nasseralbess wants to merge 3 commits intomasterfrom
Open
enriching: added run_numbers field for the cms datasets (#3752)#3752nasseralbess wants to merge 3 commits intomasterfrom
nasseralbess wants to merge 3 commits intomasterfrom
Conversation
nasseralbess
force-pushed
the
enrich_cms_datasets
branch
from
e9c1641 to
2b36cbe
Compare
katilp
reviewed
Jul 6, 2025
Member
katilp
left a comment
katilp
left a comment
There was a problem hiding this comment.
Thanks! Looks good.
Would you just check recid 35? It is a bit unlikely that it only contains events from one run number.
Member
|
OK; I looked in the files of that record. The run information in the files is consistent with DAS and with what you see but unfortunately wrong. So we cannot add the run numbers to recid 35, just leave that record out, |
nasseralbess
force-pushed
the
enrich_cms_datasets
branch
from
291fdc9 to
2897911
Compare
Member
Author
|
Alright, pushed again without run_numbers for record 35. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I retrieved the run numbers for each dataset and updated the fields as mentioned in issue #3745