Skip to content

ci: use minikube 1.38.1#6138

Merged
mergify[bot] merged 1 commit into
ceph:develfrom
nixpanic:rebase/minikube/v1.38.1
Mar 5, 2026
Merged

ci: use minikube 1.38.1#6138
mergify[bot] merged 1 commit into
ceph:develfrom
nixpanic:rebase/minikube/v1.38.1

Conversation

@nixpanic
Copy link
Copy Markdown
Member

@nixpanic nixpanic commented Feb 26, 2026

minikube 1.38.1 has official support for Kubernetes 1.35. It seems to
work with minikube 1.38.0 already too, but maybe there are improvements
that the CI benefits from.

See-also: https://github.com/kubernetes/minikube/releases/tag/v1.38.1
Depends-on: #6139

@nixpanic nixpanic added the ci/skip/multi-arch-build skip building on multiple architectures label Feb 26, 2026
@nixpanic
Copy link
Copy Markdown
Member Author

/test ci/centos/mini-e2e-operator/k8s-1.35

@mergify mergify Bot added the component/testing Additional test cases or CI work label Feb 26, 2026
@nixpanic nixpanic requested a review from a team February 26, 2026 11:28
@Madhu-1 Madhu-1 requested a review from a team February 26, 2026 11:30
@nixpanic
Copy link
Copy Markdown
Member Author

/test ci/centos/mini-e2e-operator/k8s-1.35/rbd

@iPraveenParihar
Copy link
Copy Markdown
Contributor

Failed here

failed to strip CSI Parameters of prefixed keys: found unknown parameter key "csi.storage.k8s.io/controller-modify-secret-namespace" with reserved namespace csi.storage.k8s.io/

@nixpanic
Copy link
Copy Markdown
Member Author

/test ci/centos/mini-e2e-operator/k8s-1.35

Failed with NFS, as the StorageClass contains "csi.storage.k8s.io/controller-modify-secret-*" keys that are not supported with the current external-provisioner (the operator deployment does not use CSI-sidecars from build.env).

@iPraveenParihar
Copy link
Copy Markdown
Contributor

It uses from build.env 😕

function generate_imageset_configmap() {
cat <<EOF >"${TEMP_DIR}/imageset-configmap.yaml"
apiVersion: v1
kind: ConfigMap
metadata:
name: ${IMAGESET_CONFIGMAP_NAME}
namespace: ${OPERATOR_NAMESPACE}
data:
"plugin": "quay.io/cephcsi/cephcsi:${CSI_IMAGE_VERSION}" # test image
"attacher": "${K8S_IMAGE_REPO}/csi-attacher:${CSI_ATTACHER_VERSION}"
"snapshotter": "${K8S_IMAGE_REPO}/csi-snapshotter:${CSI_SNAPSHOTTER_VERSION}"
"provisioner": "${K8S_IMAGE_REPO}/csi-provisioner:${CSI_PROVISIONER_VERSION}"
"registrar": "${K8S_IMAGE_REPO}/csi-node-driver-registrar:${CSI_NODE_DRIVER_REGISTRAR_VERSION}"
"resizer": "${K8S_IMAGE_REPO}/csi-resizer:${CSI_RESIZER_VERSION}"
EOF
}

from logs I see the external-provisioner is v6.1.1 (latest)

  W0226 11:33:50.322897       1 feature_gate.go:352] Setting GA feature gate Topology=false. It will be removed in a future release.
  W0226 11:33:50.322974       1 feature_gate.go:352] Setting GA feature gate HonorPVReclaimPolicy=true. It will be removed in a future release.
  I0226 11:33:50.322982       1 feature_gate.go:385] feature gates: {map[HonorPVReclaimPolicy:true Topology:false]}
  I0226 11:33:50.322998       1 csi-provisioner.go:170] "Version" version="v6.1.1"

@nixpanic
Copy link
Copy Markdown
Member Author

Testing NFS (uses VolumeAttributesClass) only works with external-provisioner from the master branch, the :canary tag. Older Kubernetes versions do not have VolumeAttributesClass support, so those should work with released versions.

@nixpanic
Copy link
Copy Markdown
Member Author

/test ci/centos/mini-e2e-operator/k8s-1.34

@nixpanic
Copy link
Copy Markdown
Member Author

Testing NFS (uses VolumeAttributesClass) only works with external-provisioner from the master branch, the :canary tag. Older Kubernetes versions do not have VolumeAttributesClass support, so those should work with released versions.

Reported as #6139.

@nixpanic
Copy link
Copy Markdown
Member Author

nixpanic commented Mar 2, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 2, 2026

Merge Queue Status

🛑 Queue command has been cancelled

@nixpanic
Copy link
Copy Markdown
Member Author

nixpanic commented Mar 4, 2026

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 4, 2026

rebase

✅ Branch has been successfully rebased

@ceph-csi-bot ceph-csi-bot force-pushed the rebase/minikube/v1.38.1 branch from 4331c38 to 8cf0346 Compare March 4, 2026 13:03
@nixpanic
Copy link
Copy Markdown
Member Author

nixpanic commented Mar 4, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 4, 2026

queue

☑️ Command queue ignored because it is already running from a previous command.

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Mar 4, 2026
@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.35

@Rakshith-R
Copy link
Copy Markdown
Contributor

@Mergifyio rebase

minikube 1.38.1 has official support for Kubernetes 1.35. It seems to
work with minikube 1.38.0 already too, but maybe there are improvements
that the CI benefits from.

See-also: https://github.com/kubernetes/minikube/releases/tag/v1.38.1
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@ceph-csi-bot ceph-csi-bot force-pushed the rebase/minikube/v1.38.1 branch from b33a95a to 852c42c Compare March 5, 2026 06:20
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 5, 2026

rebase

✅ Branch has been successfully rebased

@mergify mergify Bot removed the dequeued label Mar 5, 2026
@Rakshith-R Rakshith-R removed the ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. label Mar 5, 2026
@Rakshith-R
Copy link
Copy Markdown
Contributor

@Mergifyio queue

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 5, 2026

Merge Queue Status

🛑 Queue command has been cancelled

@Rakshith-R Rakshith-R added the ok-to-test Label to trigger E2E tests label Mar 5, 2026
@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.35

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 5, 2026
@nixpanic
Copy link
Copy Markdown
Member Author

nixpanic commented Mar 5, 2026

@nixpanic I think because you referenced this PR as Fixed in one of your PR. Mergify closed this PR. Reopening

Oh, that's stupid. I only referenced a comment in this PR. Thanks for noticing!

@Rakshith-R Rakshith-R added the ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. label Mar 5, 2026
@nixpanic
Copy link
Copy Markdown
Member Author

nixpanic commented Mar 5, 2026

/retest ci/centos/mini-e2e/k8s-1.35

@nixpanic
Copy link
Copy Markdown
Member Author

nixpanic commented Mar 5, 2026

/retest ci/centos/mini-e2e/k8s-1.35

Failed with some Ceph error:

  [FAILED] failed to validate rbd images in pool replicapool trash: failed to list images in trash 2026-03-05T10:37:54.381+0000 7fc4b68d7640 -1 monclient: handle_auth_reply_more no authorizer?

@mergify mergify Bot added the queued label Mar 5, 2026
@mergify mergify Bot merged commit 5e9ca0d into ceph:devel Mar 5, 2026
41 checks passed
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 5, 2026

Merge Queue Status

Rule: default


  • Entered queue2026-03-05 14:24 UTC
  • Checks passed · in-place
  • Merged2026-03-05 14:25 UTC · at 852c42c64dc7636179a8407b2f9e4478351c2193

This pull request spent 19 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify mergify Bot removed the queued label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants