Skip to content

New features#134

Open
dhananjaysathe wants to merge 4 commits intocelery:masterfrom
rapyuta-robotics:master
Open

New features#134
dhananjaysathe wants to merge 4 commits intocelery:masterfrom
rapyuta-robotics:master

Conversation

@dhananjaysathe
Copy link
Copy Markdown

Hey there ,
i added a bunch of features to the librabbitmq code as a part of stuff i needed, others may find these useful. I know this is a big set of changes , but broadly

  • adds support for connection blocking with publisher confirms
  • adds support for basic ssl endpoints (no fancy ca certs etc) -> move to cmake
  • bumps the version of rabbitmq-c to latest (i neeed the perf / sni improvements)

I am happy to have you look at it and make individual prs for the features you would want to upstream and then focus on polishing those for merge

add support for ssl
bump rabbitmq-c to latest master  (some fixes plus sni)
add support for blocking publisher confirms
cleanup the mess in setup.py
Copy link
Copy Markdown
Contributor

@thedrow thedrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks like a good addition.
See notes.

Comment thread Makefile Outdated
Comment thread setup.py Outdated
Comment thread setup.py
@thedrow
Copy link
Copy Markdown
Contributor

thedrow commented Apr 30, 2020

Hi @dhananjaysathe

Version 0.10 was released.
If you can update the PR, I'll merge it.

@spumer
Copy link
Copy Markdown

spumer commented Mar 11, 2021

Any updates?

@thedrow
Copy link
Copy Markdown
Contributor

thedrow commented Mar 11, 2021

@spumer None. Feel free to revive this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants