Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ emcc \
'setValue', \
'lengthBytesUTF8', \
'stringToUTF8', \
'HEAPU32', \
'HEAPU8', \
'HEAP8', \
'stringToNewUTF8'
]" \
-s INCOMING_MODULE_JS_API="[
Expand Down
12 changes: 11 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"typescript-eslint": "8.18.2"
},
"dependencies": {
"@types/emscripten": "1.39.10"
"@types/emscripten": "1.39.10",
"isutf8": "^4.0.1"
}
}
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ export { default as LuaTypeExtension } from './type-extension'
export { decorateFunction } from './type-extensions/function'
export { decorateProxy } from './type-extensions/proxy'
export { decorateUserdata } from './type-extensions/userdata'
export { Uint8ArrayExtension } from './type-extensions/uint8Array'
export * from './types'
4 changes: 4 additions & 0 deletions src/luawasm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ export default class LuaWasm {
public lua_tointegerx: (L: LuaState, idx: number, isnum: number | null) => bigint
public lua_toboolean: (L: LuaState, idx: number) => number
public lua_tolstring: (L: LuaState, idx: number, len: number | null) => string
public lua_ptr_tolstring: (L: LuaState, idx: number, len: number | null) => number
public lua_rawlen: (L: LuaState, idx: number) => number
public lua_tocfunction: (L: LuaState, idx: number) => number
public lua_touserdata: (L: LuaState, idx: number) => number
Expand All @@ -123,6 +124,7 @@ export default class LuaWasm {
public lua_pushnumber: (L: LuaState, n: number) => void
public lua_pushinteger: (L: LuaState, n: bigint) => void
public lua_pushlstring: (L: LuaState, s: string | number | null, len: number) => string
public lua_ptr_pushlstring: (L: LuaState, s: string | number | null, len: number) => number
public lua_pushstring: (L: LuaState, s: string | number | null) => string
public lua_pushcclosure: (L: LuaState, fn: number, n: number) => void
public lua_pushboolean: (L: LuaState, b: number) => void
Expand Down Expand Up @@ -268,6 +270,7 @@ export default class LuaWasm {
this.lua_tointegerx = this.cwrap('lua_tointegerx', 'number', ['number', 'number', 'number'])
this.lua_toboolean = this.cwrap('lua_toboolean', 'number', ['number', 'number'])
this.lua_tolstring = this.cwrap('lua_tolstring', 'string', ['number', 'number', 'number'])
this.lua_ptr_tolstring = this.cwrap('lua_tolstring', 'number', ['number', 'number', 'number'])
this.lua_rawlen = this.cwrap('lua_rawlen', 'number', ['number', 'number'])
this.lua_tocfunction = this.cwrap('lua_tocfunction', 'number', ['number', 'number'])
this.lua_touserdata = this.cwrap('lua_touserdata', 'number', ['number', 'number'])
Expand All @@ -280,6 +283,7 @@ export default class LuaWasm {
this.lua_pushnumber = this.cwrap('lua_pushnumber', null, ['number', 'number'])
this.lua_pushinteger = this.cwrap('lua_pushinteger', null, ['number', 'number'])
this.lua_pushlstring = this.cwrap('lua_pushlstring', 'string', ['number', 'string|number', 'number'])
this.lua_ptr_pushlstring = this.cwrap('lua_pushlstring', 'string', ['number', 'string|number', 'number'])

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type here is string, but you added the return as number on the field?

this.lua_pushstring = this.cwrap('lua_pushstring', 'string', ['number', 'string|number'])
this.lua_pushcclosure = this.cwrap('lua_pushcclosure', null, ['number', 'number', 'number'])
this.lua_pushboolean = this.cwrap('lua_pushboolean', null, ['number', 'number'])
Expand Down
20 changes: 19 additions & 1 deletion src/thread.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type LuaWasm from './luawasm'
import MultiReturn from './multireturn'
import { Pointer } from './pointer'
import LuaTypeExtension from './type-extension'
import isUtf8 from 'isutf8'
import {
LUA_MULTRET,
LuaEventMasks,
Expand Down Expand Up @@ -281,7 +282,7 @@ export default class Thread {
case LuaType.Number:
return this.lua.lua_tonumberx(this.address, index, null)
case LuaType.String:
return this.lua.lua_tolstring(this.address, index, null)
return this.readStringPtr(index)
case LuaType.Boolean:
return Boolean(this.lua.lua_toboolean(this.address, index))
case LuaType.Thread:
Expand Down Expand Up @@ -413,4 +414,21 @@ export default class Thread {
private getValueDecorations(value: any): Decoration {
return value instanceof Decoration ? value : new Decoration(value, {})
}

private readStringPtr(index: number): Uint8Array<ArrayBufferLike> | string {
const lenPtr = this.lua.module._malloc(PointerSize)
const bufferPtr = this.lua.lua_ptr_tolstring(this.address, index, lenPtr)
const length = this.lua.module.HEAPU32[lenPtr / Uint32Array.BYTES_PER_ELEMENT]
this.lua.module._free(lenPtr)

const dataView = this.lua.module.HEAPU8.subarray(bufferPtr, bufferPtr + length)

if (isUtf8(dataView)) {
const decoder = new TextDecoder('utf-8')
const decodedString = decoder.decode(dataView)
return decodedString
}

return dataView
}
}
30 changes: 30 additions & 0 deletions src/type-extensions/uint8Array.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import LuaTypeExtension from '../type-extension'
import Global from '../global'
import Thread from '../thread'
import { Decoration } from '../decoration'

export class Uint8ArrayExtension extends LuaTypeExtension<unknown> {
constructor(thread: Global) {
super(thread, 'js_unit8array')
}

public pushValue(thread: Thread, { target }: Decoration<Uint8Array>): boolean {
if (target instanceof Uint8Array) {
thread.lua.lua_checkstack(thread.address, 1)
const bufferSize = target.byteLength
const bufferPtr = thread.lua.module._malloc(bufferSize)

thread.lua.module.HEAP8.set(target, bufferPtr)
thread.lua.lua_pushlstring(thread.address, bufferPtr, bufferSize)
thread.lua.module._free(bufferPtr)

return true
}

return false
}

public close(): void {
// Nothing to do
}
}
31 changes: 31 additions & 0 deletions test/binary.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { expect } from 'chai'
import { getEngine } from './utils.js'
import { Uint8ArrayExtension } from '../dist/index.js'

describe('Binary', () => {
it('passes utf8 buffer correctly', async () => {
const engine = await getEngine()
const b = Buffer.from('мой тёст', 'utf8')
engine.global.registerTypeExtension(100, new Uint8ArrayExtension(engine.global))
engine.global.set('str', b)

const res = await engine.doString('return tostring(str == "мой тёст")')

expect(res).to.be.equal('true')
})

it('passes binary data correctly', async () => {
// 1px png image
const img = Buffer.from(
'89504e470d0a1a0a0000000d4948445200000001000000010802000000907753de0000001974455874536f6674776172650041646f626520496d616765526561647971c9653c0000032669545874584d4c3a636f6d2e61646f62652e786d7000000000003c3f787061636b657420626567696e3d22efbbbf222069643d2257354d304d7043656869487a7265537a4e54637a6b633964223f3e203c783a786d706d65746120786d6c6e733a783d2261646f62653a6e733a6d6574612f2220783a786d70746b3d2241646f626520584d5020436f726520352e362d633133382037392e3135393832342c20323031362f30392f31342d30313a30393a30312020202020202020223e203c7264663a52444620786d6c6e733a7264663d22687474703a2f2f7777772e77332e6f72672f313939392f30322f32322d7264662d73796e7461782d6e7323223e203c7264663a4465736372697074696f6e207264663a61626f75743d222220786d6c6e733a786d703d22687474703a2f2f6e732e61646f62652e636f6d2f7861702f312e302f2220786d6c6e733a786d704d4d3d22687474703a2f2f6e732e61646f62652e636f6d2f7861702f312e302f6d6d2f2220786d6c6e733a73745265663d22687474703a2f2f6e732e61646f62652e636f6d2f7861702f312e302f73547970652f5265736f75726365526566232220786d703a43726561746f72546f6f6c3d2241646f62652050686f746f73686f702043432032303137202857696e646f7773292220786d704d4d3a496e7374616e636549443d22786d702e6969643a46323542393237393031313031314538393731334432373436344437393337362220786d704d4d3a446f63756d656e7449443d22786d702e6469643a4632354239323741303131303131453839373133443237343634443739333736223e203c786d704d4d3a4465726976656446726f6d2073745265663a696e7374616e636549443d22786d702e6969643a4632354239323737303131303131453839373133443237343634443739333736222073745265663a646f63756d656e7449443d22786d702e6469643a4632354239323738303131303131453839373133443237343634443739333736222f3e203c2f7264663a4465736372697074696f6e3e203c2f7264663a5244463e203c2f783a786d706d6574613e203c3f787061636b657420656e643d2272223f3e8503272a0000000f4944415478da62faffff3f40800100060603002b8974ad0000000049454e44ae426082',
'hex',
)
const engine = await getEngine()
engine.global.registerTypeExtension(100, new Uint8ArrayExtension(engine.global))
engine.global.set('img', img)

const res = await engine.doString('return img')

expect(Buffer.from(res).toString('hex')).to.be.equal(img.toString('hex'))
})
})