Skip to content

Prevent dynamic service deletion during upgrade #16151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhardwaj-priyanshu merged 1 commit into from
May 29, 2026
+111 −28

prevent dynamic service deletion during upgrade

c61d14f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Prevent dynamic service deletion during upgrade #16151

prevent dynamic service deletion during upgrade
c61d14f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Checkstyle completed May 29, 2026 in 0s

Checkstyle report

6 violation(s) found

Annotations

Check warning on line 435 in cdap-kubernetes/src/main/java/io/cdap/cdap/k8s/discovery/KubeDiscoveryService.java

See this annotation in the file changed.

@github-actions github-actions / Checkstyle

com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck 

Distance between variable 'service' declaration and its first usage is 5, but allowed 3.  Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

Check warning on line 572 in cdap-kubernetes/src/main/java/io/cdap/cdap/k8s/discovery/KubeDiscoveryService.java

See this annotation in the file changed.

@github-actions github-actions / Checkstyle

com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck 

'||' should be on a new line.

Check warning on line 573 in cdap-kubernetes/src/main/java/io/cdap/cdap/k8s/discovery/KubeDiscoveryService.java

See this annotation in the file changed.

@github-actions github-actions / Checkstyle

com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck 

'||' should be on a new line.

Check warning on line 574 in cdap-kubernetes/src/main/java/io/cdap/cdap/k8s/discovery/KubeDiscoveryService.java

See this annotation in the file changed.

@github-actions github-actions / Checkstyle

com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck 

'||' should be on a new line.

Check warning on line 387 in cdap-kubernetes/src/test/java/io/cdap/cdap/k8s/discovery/KubeDiscoveryServiceTest.java

See this annotation in the file changed.

@github-actions github-actions / Checkstyle

com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck 

Distance between variable 'discoverable' declaration and its first usage is 4, but allowed 3.  Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

Check warning on line 406 in cdap-kubernetes/src/test/java/io/cdap/cdap/k8s/discovery/KubeDiscoveryServiceTest.java

See this annotation in the file changed.

@github-actions github-actions / Checkstyle

com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck 

Distance between variable 'discoverable' declaration and its first usage is 5, but allowed 3.  Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
View more details on GitHub Actions