Remove deprecated paid field from MeltQuote#870
Closed
fresh3nough wants to merge 2 commits into
Closed
Conversation
- Remove paid field from PostMeltQuoteResponse model - Update mint router and ledger to not pass paid field - Update wallet v1_api to not construct responses with paid field - Fix tests that were checking for deprecated paid field - Use state property instead for checking quote payment status Fixes cashubtc#855
Collaborator
|
@fresh3nough thank you for your PR. just a heads up but the issue attached to this PR and the issue attached to this (#871) were already assigned for a reason, please do check whether an issue has been assigned or not before you attend to it, thank you. |
Author
|
@KvngMikey sorry about that, i will pay closer attention, just let me know if you want me to do anymore |
Collaborator
|
Closing, superceded by #1024 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #855