Skip to content

feat(crypto): align NUT-20/29 signatures with spec and add test vectors#1057

Open
a1denvalu3 wants to merge 4 commits into
mainfrom
fix/nut-29-batch-minting
Open

feat(crypto): align NUT-20/29 signatures with spec and add test vectors#1057
a1denvalu3 wants to merge 4 commits into
mainfrom
fix/nut-29-batch-minting

Conversation

@a1denvalu3

Copy link
Copy Markdown
Collaborator

This PR aligns NUT-20 and NUT-29 signature validation and generation with the latest spec amendments, and implements/verifies the corresponding test vectors in test_crypto.py.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.27%. Comparing base (8d23ea9) to head (4ab4593).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cashu/core/nuts/nut20.py 83.33% 5 Missing ⚠️
cashu/mint/ledger.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files         111      111           
  Lines       12431    12458   +27     
=======================================
+ Hits         9357     9378   +21     
- Misses       3074     3080    +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@a1denvalu3 a1denvalu3 self-assigned this Jun 26, 2026
@a1denvalu3 a1denvalu3 force-pushed the fix/nut-29-batch-minting branch from b11a63b to 4ab4593 Compare June 26, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant