test(fuzz): make client fixture module-scoped to prevent startup failures#1051
Open
callebtc wants to merge 1 commit into
Open
test(fuzz): make client fixture module-scoped to prevent startup failures#1051callebtc wants to merge 1 commit into
callebtc wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
- Coverage 74.32% 74.29% -0.03%
==========================================
Files 111 111
Lines 12372 12372
==========================================
- Hits 9195 9192 -3
- Misses 3177 3180 +3 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes fuzz test failures where alternating tests failed during
TestClient(app)setup withSystemExit(1) / CancelledError.The function-scoped
clientfixture was starting and shutting down the global FastAPI app for every fuzz test. After the first teardown, the next startup failed (likely due to the management RPC server lifecycle / global state not being fully reset). Making the fixture module-scoped starts the app once for the entire fuzz module and avoids the lifecycle conflict.Verified with
make test: