feat(mint): Add Spark L2 wallet backend#1019
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 75.15% 74.25% -0.91%
==========================================
Files 111 112 +1
Lines 12372 12580 +208
==========================================
+ Hits 9298 9341 +43
- Misses 3074 3239 +165 ☔ View full report in Codecov by Harness. |
| # We run this in a thread because breez SDK connect is blocking in python (currently) | ||
| # Actually, `connect` is async in Python. Let's await it. | ||
| # wait, breez_sdk_spark python binding functions are actually async? No they are sync. | ||
| if inspect.iscoroutinefunction(breez_sdk_spark.connect): |
There was a problem hiding this comment.
this is horrible and should be part of the codebase as well.
| ) | ||
|
|
||
| req = breez_sdk_spark.GetInfoRequest(ensure_synced=False) | ||
| if inspect.iscoroutinefunction(self.sdk.get_info): |
There was a problem hiding this comment.
same here. figure this out this from the documentation.
|
Thanks for the feedback! I've removed all |
|
@callebtc Should we derive a mnemonic from the mint private key, or should we let it as is where the operator specifies a mnemonic for the breeze sdk as well as the secret for the mint? |
…and correctly converts to sats
…or Spark L2 backend
…ributeError on incoming payments
…L2 event listener to prevent uniffi crashes
…rounds in Breez SDK integration
…t all exceptions as PENDING
… siphoning attacks
a1denvalu3
force-pushed
the
feat/spark-l2-backend
branch
from
0219176 to
7115a65
Compare
2 participants
A