add more batch mint tests#1015
Open
callebtc wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 75.27% 75.32% +0.05%
==========================================
Files 111 111
Lines 12431 12431
==========================================
+ Hits 9357 9364 +7
+ Misses 3074 3067 -7 ☔ View full report in Codecov by Harness. |
- invalid_signature: generate one secret to match the single output - mixed_locked_unlocked: make the second quote actually unlocked (request_mint always sets a NUT-20 pubkey, so both were locked) - drop expired_quotes: mint quote expiry is not persisted/enforced - atomicity_one_invalid: trigger the failure via an invalid signature instead of (unenforced) expiry
KvngMikey
force-pushed
the
batch-minting-tests
branch
from
ca2dfe9 to
8807dca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.