Skip to content

feat(ffi): expose NUT-27 mint backup#2153

Merged
thesimplekid merged 1 commit into
cashubtc:mainfrom
thesimplekid:nostr_backup
Jun 26, 2026
Merged

feat(ffi): expose NUT-27 mint backup#2153
thesimplekid merged 1 commit into
cashubtc:mainfrom
thesimplekid:nostr_backup

Conversation

@thesimplekid

Copy link
Copy Markdown
Collaborator

Add WalletRepository FFI methods for deriving the backup public key, publishing mint backups, restoring mints, and fetching a backup preview. Also avoid duplicate mint URLs in backups and fix the example's NUT label.

Description


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.88%. Comparing base (a5cace5) to head (08fde41).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/cdk-ffi/src/wallet_repository.rs 0.00% 32 Missing ⚠️
crates/cdk/src/wallet/nostr_backup.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
- Coverage   71.91%   71.88%   -0.04%     
==========================================
  Files         356      356              
  Lines       74500    74532      +32     
==========================================
- Hits        53577    53574       -3     
- Misses      20923    20958      +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asmogo asmogo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@thesimplekid thesimplekid added this to the 0.17.3 milestone Jun 26, 2026
Add WalletRepository FFI methods for deriving the backup public key, publishing mint backups, restoring mints, and fetching a backup preview. Also avoid duplicate mint URLs in backups and fix the example's NUT label.
@thesimplekid thesimplekid merged commit 08fde41 into cashubtc:main Jun 26, 2026
7 checks passed
@thesimplekid thesimplekid deleted the nostr_backup branch June 26, 2026 12:47
@github-project-automation github-project-automation Bot moved this from Backlog to Done in CDK Jun 26, 2026
@cdk-bot

cdk-bot commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for v0.17.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants