fix(regtest): wait for LDK BOLT12 readiness#2152
Closed
thesimplekid wants to merge 2 commits into
Closed
Conversation
thesimplekid
force-pushed
the
bolt12_regtest_fix
branch
from
c89f0f7 to
cb26e38
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c89f0f7403
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
==========================================
- Coverage 71.88% 71.56% -0.32%
==========================================
Files 356 356
Lines 74532 74857 +325
==========================================
- Hits 53574 53570 -4
- Misses 20958 21287 +329 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thesimplekid
force-pushed
the
bolt12_regtest_fix
branch
from
cb26e38 to
a30552b
Compare
Gate LN regtest startup on an actual LDK BOLT12 quote payment before\nrunning the test suite. Reconnect CLN to the restarted LDK mint node avoid dropping the stopped setup node, which can panic in ldk-node 0.7. Keep CLN fetchinvoice bounded with a Tokio timeout instead of sending the\nRPC timeout field, which CLN rejects when serialized as a float.
thesimplekid
force-pushed
the
bolt12_regtest_fix
branch
2 times, most recently
from
59705c9 to
66b3fab
Compare
Retry the LDK-to-LND channel open until both sides report the expected active/usable channel. Validate the full LDK/CLN/LND topology before signaling regtest readiness, and include channel summaries when setup fails. Retry CLN peer reconnect during BOLT12 readiness, reconnect CLN RPC after fetchinvoice timeouts, derive the LDK P2P port from the configured mint port, and preserve early regtest process exit status in the integration test wrapper. For the LDK mint BOLT12 melt integration test, retry the melt with a fresh CLN single-use offer if the first outgoing BOLT12 payment attempt fails.
thesimplekid
force-pushed
the
bolt12_regtest_fix
branch
from
66b3fab to
c3cd0d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate LN regtest startup on an actual LDK BOLT12 quote payment before\nrunning the test suite. Reconnect CLN to the restarted LDK mint node
avoid dropping the stopped setup node, which can panic in ldk-node 0.7.
Keep CLN fetchinvoice bounded with a Tokio timeout instead of sending the\nRPC timeout field, which CLN rejects when serialized as a float.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)