Skip to content

feat(nut04/05): optional amount#2146

Draft
asmogo wants to merge 2 commits into
cashubtc:mainfrom
asmogo:fix/optional-amounts
Draft

feat(nut04/05): optional amount#2146
asmogo wants to merge 2 commits into
cashubtc:mainfrom
asmogo:fix/optional-amounts

Conversation

@asmogo

@asmogo asmogo commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Description


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@github-project-automation github-project-automation Bot moved this to Backlog in CDK Jun 23, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.59%. Comparing base (d481edc) to head (fdf427a).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/cdk-payment-processor/src/proto/server.rs 0.00% 2 Missing ⚠️
crates/cdk-fake-wallet/src/lib.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
+ Coverage   71.55%   71.59%   +0.04%     
==========================================
  Files         356      356              
  Lines       73999    74131     +132     
==========================================
+ Hits        52950    53077     +127     
- Misses      21049    21054       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant