chore(scripts): unbreak renovate by narrowing tsconfig to the CI script#686
Merged
Conversation
The crypto split in #667 renamed src/crypto/bls to src/crypto/curve_bls but left generate-nuts-vectors.ts pointing at the old path, which broke renovate's build:scripts step. Narrow scripts/tsconfig.json to compile only UpdateMakefileMintVersion.ts (the sole script CI runs) so dev/bench files can't block renovate again, and fix the stale import.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 53 53
Lines 4964 4964
Branches 1224 1224
=======================================
Hits 4584 4584
Misses 161 161
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
../src/crypto/blsimport inscripts/generate-nuts-vectors.ts(renamed tocurve_blsin refactor(crypto): split curve primitives #667)scripts/tsconfig.jsonincludeto justUpdateMakefileMintVersion.tsso the renovate workflow only compiles what it runsMotivation
The nightly renovate workflow runs
npm run update-docker-versions, which callsbuild:scripts(tsc -p scripts/tsconfig.json). The tsconfig included every.tsunderscripts/, so a stale import in the one-shotgenerate-nuts-vectors.tsgenerator (left behind by the crypto split in #667) was enough to fail the whole step.UpdateMakefileMintVersion.tsis the only script invoked from CI. The bench scripts and the nuts-vector generator are run ad-hoc vianpx tsx. Narrowing the tsconfig include keeps CI focused on what it actually runs and prevents future dev/bench scripts from blocking renovate.Test plan
npm run update-docker-versionssucceeds locallydist-scripts/contains onlyUpdateMakefileMintVersion.js