fix(keychain): float→BigInt crash in token send + HMR provider exports by tarrencev · Pull Request #2623 · cartridge-gg/controller

tarrencev · 2026-06-18T22:36:32Z

From a PostHog error triage of the Controller. Two fixes:

C1 — real prod bug: float passed to `BigInt()` in token send

SendTokenDrawer computed the base-unit amount as amount * 10 ** decimals and passed it to BigInt(). A fractional amount yields a non-integer float — e.g. 0.0045 * 10**18 = 4499999999999999.5 — which throws cannot be converted to a BigInt because it is not an integer. Observed in production (x.cartridge.gg, /inventory/token/…). Fix: parse the raw decimal input string into base units exactly with bigint math (parseTokenAmount), thread the input string through amount.tsx, and treat invalid/over-precision input as no-amount. Regression test added (0.0045 @ 18 decimals).

C2 — dev HMR error class: `react-refresh/only-export-components`

Provider modules exported createContext()/hooks/constants alongside the Provider, breaking Vite Fast Refresh and invalidating context identity on hot-reload — cause of the ~100 dev-only useX must be used within XProvider errors. Enabled react-refresh/only-export-components (warn) and split the offenders (starterpack, onchain-purchase, credit-purchase, upgrade, wallets) into context/provider/hook modules.

Verification

tsc -b, lint (0 errors), format:check, keychain tests (579 passing) green. Triaged + implemented with Codex; the "credits" PostHog errors were an unmerged local WIP branch (not on main) — nothing to fix there.

🤖 Generated with Claude Code

C1: SendTokenDrawer computed base units as amount * 10**decimals and passed the result to BigInt(), so a fractional amount produced a non-integer float (0.0045 * 10**18 = 4499999999999999.5) and threw 'cannot be converted to a BigInt because it is not an integer' (seen in prod on /inventory/token). Parse the raw decimal input string into base units exactly with bigint math (parseTokenAmount), thread the input string through amount.tsx, and treat invalid/over-precision input as no-amount. Adds a regression test (0.0045 @ 18). C2: provider modules exported createContext()/hooks/constants alongside the Provider, breaking Vite Fast Refresh and invalidating context identity on hot-reload (cause of dev-only 'useX must be used within XProvider' errors). Enable react-refresh/only-export-components (warn) and split the offenders (starterpack, onchain-purchase, credit-purchase, upgrade, wallets) into context/provider/hook modules. Targeted modules warning-clean; tsc, lint (0 errors), format, and keychain tests (579 passing) green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-06-18T22:36:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
controller-example-next	Ready	Preview	Jun 19, 2026 12:40am
controller-ui	Ready	Preview	Jun 19, 2026 12:40am
keychain	Ready	Preview	Jun 19, 2026 12:40am
keychain-storybook	Ready	Preview	Jun 19, 2026 12:40am

The C2 split moved CONTROLLER_VERSIONS/UpgradeContext/UpgradeInterface/ UpgradeProviderProps out of provider/upgrade.tsx into upgrade-context.ts. .storybook/ is outside the package tsconfig (so tsc -b didn't catch it), but the Vercel keychain-storybook build compiles it — fixing the stale import path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

gillen-pitchclick

Static guard found blocking identifier/type-safety issues: removed symbols still referenced, or unsafe BigInt/number conversion.

Automated review could not parse the agent response.

gillen-pitchclick · 2026-06-19T14:52:21Z

  UpgradeInterface,
  UpgradeProviderProps,
-} from "../src/components/provider/upgrade";
+} from "../src/components/provider/upgrade-context";


Blocking: context is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:21Z

@@ -1,8 +1,8 @@
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
-import { STABLE_CONTROLLER } from "@/components/provider/upgrade";
+import { STABLE_CONTROLLER } from "@/components/provider/upgrade-context";


Blocking: context is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:21Z

    ) {
      return "";
    } else {
+      const baseUnitAmount = parseTokenAmount(


Blocking: parseTokenAmount is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:21Z

+export type ControllerVersionInfo = {
+  version: string;
+  hash: string;
+  outsideExecutionVersion: OutsideExecutionVersion;


Blocking: OutsideExecutionVersion is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:22Z

+  changes: string[];
+};
+
+export const CONTROLLER_VERSIONS: ControllerVersionInfo[] = [


Blocking: ControllerVersionInfo is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:23Z

+  children: ReactNode;
+}
+
+/** A chain whose account is behind the target version. */


Blocking: is is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:23Z

+}
+
+/** A chain whose account is behind the target version. */
+export type OutdatedChain = { rpcUrl: string; version: ControllerVersionInfo };


Blocking: ControllerVersionInfo is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:23Z

  determineUpgradePath,
-  useUpgrade,
-} from "./upgrade";
+} from "./upgrade-context";


Blocking: context is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:23Z

-    (v) => addAddressPadding(v.hash) === addAddressPadding(classHash),
-  );
+import {
+  BETA_CONTROLLER,


Blocking: BETA_CONTROLLER is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:52:23Z

-  );
+import {
+  BETA_CONTROLLER,
+  ControllerVersionInfo,


Blocking: ControllerVersionInfo is still referenced here, but this diff removes its definition/export.

gillen-pitchclick

Static guard found blocking identifier/type-safety issues: removed symbols still referenced, or unsafe BigInt/number conversion.

Automated review could not parse the agent response.

gillen-pitchclick · 2026-06-19T14:59:54Z

@@ -1,8 +1,8 @@
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
-import { STABLE_CONTROLLER } from "@/components/provider/upgrade";
+import { STABLE_CONTROLLER } from "@/components/provider/upgrade-context";


Blocking: context is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:54Z

    ) {
      return "";
    } else {
+      const baseUnitAmount = parseTokenAmount(


Blocking: parseTokenAmount is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:54Z

+export type ControllerVersionInfo = {
+  version: string;
+  hash: string;
+  outsideExecutionVersion: OutsideExecutionVersion;


Blocking: OutsideExecutionVersion is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:54Z

+  changes: string[];
+};
+
+export const CONTROLLER_VERSIONS: ControllerVersionInfo[] = [


Blocking: ControllerVersionInfo is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:54Z

+  {
+    version: "1.0.4",
+    hash: "0x24a9edbfa7082accfceabf6a92d7160086f346d622f28741bf1c651c412c9ab",
+    outsideExecutionVersion: OutsideExecutionVersion.V2,


Blocking: OutsideExecutionVersion is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:55Z

+}
+
+/** A chain whose account is behind the target version. */
+export type OutdatedChain = { rpcUrl: string; version: ControllerVersionInfo };


Blocking: ControllerVersionInfo is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:55Z

  determineUpgradePath,
-  useUpgrade,
-} from "./upgrade";
+} from "./upgrade-context";


Blocking: context is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:55Z

-    (v) => addAddressPadding(v.hash) === addAddressPadding(classHash),
-  );
+import {
+  BETA_CONTROLLER,


Blocking: BETA_CONTROLLER is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:55Z

-  );
+import {
+  BETA_CONTROLLER,
+  ControllerVersionInfo,


Blocking: ControllerVersionInfo is still referenced here, but this diff removes its definition/export.

gillen-pitchclick · 2026-06-19T14:59:55Z

+import {
+  BETA_CONTROLLER,
+  ControllerVersionInfo,
+  determineUpgradePath,


Blocking: determineUpgradePath is still referenced here, but this diff removes its definition/export.

vercel Bot deployed to Preview – controller-ui June 18, 2026 22:37 View deployment

vercel Bot had a problem deploying to Preview – keychain-storybook June 18, 2026 22:37 Failure

vercel Bot deployed to Preview – keychain June 18, 2026 22:37 View deployment

vercel Bot deployed to Preview – controller-example-next June 19, 2026 00:39 View deployment

vercel Bot deployed to Preview – controller-ui June 19, 2026 00:40 View deployment

vercel Bot deployed to Preview – keychain June 19, 2026 00:40 View deployment

vercel Bot deployed to Preview – keychain-storybook June 19, 2026 00:40 View deployment

gillen-pitchclick Bot requested changes Jun 19, 2026

View reviewed changes

Conversation

tarrencev commented Jun 18, 2026

C1 — real prod bug: float passed to BigInt() in token send

C2 — dev HMR error class: react-refresh/only-export-components

Verification

Uh oh!

vercel Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gillen-pitchclick Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

gillen-pitchclick Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

C1 — real prod bug: float passed to `BigInt()` in token send

C2 — dev HMR error class: `react-refresh/only-export-components`

vercel Bot commented Jun 18, 2026 •

edited

Loading