requirements: add six to list of requirements#15
Open
samuelsimko wants to merge 1 commit into
Open
Conversation
|
Looks ok to me, but it seems the function using six has a bug anyway? (buffer is not defined). For MPI, not sure if HPC compatibility on local devices is really needed. |
Author
|
As for MPI, you might be right about HPC compatibility not being needed on local devices. |
|
I didn't know about the python2 behaviour, thank you. You are definitely right, mpi4py should be added to the requirements / README at some point.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sixpython library is used in the LensIt code, but does not figure in the list of requirements.LensIt is expecting
mpi4pyto be installed as well for better performance, which requires the libopenmpi-dev package to be installed on Debian-based Linux distributions, and the openmpi-devel package to be installed on RPM-based Linux distributions.Maybe this can be added to the README, or to the requirements.txt as well ?