carlspring/vertx-codeql-queries#14 : Implement a CodeQL query that checks for invocations of Vertx.vertx() - #15
Open
carlspring wants to merge 3 commits into
Open
carlspring/vertx-codeql-queries#14 : Implement a CodeQL query that checks for invocations of Vertx.vertx()#15carlspring wants to merge 3 commits into
carlspring wants to merge 3 commits into
Conversation
carlspring
force-pushed
the
issues/14/vertx-vertx
branch
from
December 8, 2023 02:38
834e8d9 to
2c798bf
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new Java CodeQL query to detect direct invocations of io.vertx.core.Vertx.vertx() and wires it into the repository’s query-test harness, along with a query help file and a sample Java file.
Changes:
- Added
InvocationOfVertxVertx.qlto flagVertx.vertx()calls with zero arguments. - Added a new query-test folder (
InvocationOfVertxVertx) with Maven setup, extractor options,.qlref, and expected results. - Added a
.qhelphelp file and a Java example undersrc/main/java.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/ql/InvocationOfVertxVertx.ql | Implements the new query matching Vertx.vertx() calls. |
| src/main/ql/InvocationOfVertxVertx.qhelp | Adds end-user help content for the new query. |
| src/main/java/org/carlspring/security/vertx/http/InvocationOfVertxVertx.java | Adds a Java example that invokes Vertx.vertx(). |
| src/test/ql/test/query-tests/InvocationOfVertxVertx/pom.xml | Test-project Maven dependencies for query extraction. |
| src/test/ql/test/query-tests/InvocationOfVertxVertx/options | Java extractor options for the query test. |
| src/test/ql/test/query-tests/InvocationOfVertxVertx/InvocationOfVertxVertx.qlref | References the query under test. |
| src/test/ql/test/query-tests/InvocationOfVertxVertx/InvocationOfVertxVertx.java | Finding-producing test case for Vertx.vertx(). |
| src/test/ql/test/query-tests/InvocationOfVertxVertx/InvocationOfVertxVertx.expected | Expected results for the query test run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+11
to
+14
| public void start() | ||
| { | ||
| Vertx.vertx(); | ||
| } |
Comment on lines
+7
to
+11
| An HTTP server which does not use SSL/TLS is vulnerable to man-in-the-middle attacks. | ||
| </p> | ||
| <p> | ||
| Please, note that it may be safe to ignore this, only if you intend your application to be placed | ||
| behind a loadbalancer, which is itself securing the connections with the appropriate certificates. |
…ertx() * Implemented CodeQL query. * Implemented test case. * Added a query help file.
carlspring
force-pushed
the
issues/14/vertx-vertx
branch
from
August 3, 2026 23:43
2c798bf to
22f1191
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: carlspring <1436265+carlspring@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request fixes #14 .
Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?
Code Review And Pre-Merge Checklist
Insecureexample.Secureexample.