feat(cardinal):Bring window to focus on the active Space(#188)#209
Open
xiaxiansong wants to merge 2 commits into
Open
feat(cardinal):Bring window to focus on the active Space(#188)#209xiaxiansong wants to merge 2 commits into
xiaxiansong wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds macOS-specific window activation behavior so Cardinal’s main window moves to the currently active Space before being shown/focused.
Changes:
- Refactors window activation through a platform-specific wrapper.
- On macOS, schedules activation on the main thread and updates
NSWindowCollectionBehavior. - Adds macOS-only unit tests for the collection behavior flag transformation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在哪个桌面触发唤醒，Cardinal 的窗口就移动到那个 Space 并显示出来，用快捷键唤出 cardinal 窗口时不会再回到启动桌面