Repository navigation
Conversation
tonyandrewmeyer
left a comment
tonyandrewmeyer
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This looks good - one annotation that I think is a slip (discard), and a question about the eq signatures that also applies to #2887, so it'd be good to settle it once.
jorenham
force-pushed
the
typing/framework/coverage
branch
from
November 13, 2026 00:18
d2141c9 to
b45bdfa
Compare
jorenham
force-pushed
the
typing/framework/coverage
branch
from
November 13, 2026 00:20
b45bdfa to
438a0d6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases public type coverage (
pyrefly coverage check --public only) from 85.74% to 88.39% (+2.65%), andops.frameworkitself is now 100% covered. This also adds docstrings for the Instance attributes of some of the previously unannotatedops.frameworkclasses, which will show up in the reference docs. Additionally, this tightens some annotations in the rich comparison dunders, and explicitly marks type aliases asTypeAlias.