Repository navigation
fix: use CheckLevel.UNSET for an unset level in testing.CheckInfo - #2878
Merged
tonyandrewmeyer merged 4 commits intoNov 13, 2026
Merged
tonyandrewmeyer merged 4 commits into
tonyandrewmeyer merged 4 commits into
Conversation
Real Pebble gives CheckLevel.UNSET for a check with no level, but in Scenario a charm saw None, so a charm comparing against CheckLevel.UNSET behaved differently in its tests than in production. None is still accepted, and means the same as not passing a level. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
benhoyt
approved these changes
Nov 9, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every check info in the mock comes from CheckInfo._to_ops(), whose level is now always a CheckLevel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MattPatchava
approved these changes
Nov 12, 2026
…/scenario-check-info-level-unset # Conflicts: # ops/pebble.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Scenario, a
CheckInfowith no level gave the charmNone, where real Pebble givesCheckLevel.UNSET, so a charm comparing againstCheckLevel.UNSETbehaved differently in its tests than in production.Behaviour change
testing.CheckInfo.levelis nowCheckLevel.UNSETrather thanNonewhen no level is given, in both the input and output state. Passinglevel=Nonestill works, but a test assertingcheck_info.level is Nonewill fail.A hyrum run on #2854, which included this change, found no new failures.