Fix daemon rpc client logger lifetime issue#4841
Open
xmkg wants to merge 11 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4841 +/- ##
==========================================
- Coverage 87.78% 87.61% -0.16%
==========================================
Files 269 270 +1
Lines 14573 14537 -36
==========================================
- Hits 12791 12735 -56
- Misses 1782 1802 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xmkg
force-pushed
the
bugfix/fix-daemon-rpc-client-logger-lifetime-issue
branch
3 times, most recently
from
b017368 to
1eae221
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Use the new DaemonRpcContext class to pass around context to the fns. DaemonRpc class now takes logger as a constructor arg. Streamline request read calls into dispatch function. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
force-pushed
the
bugfix/fix-daemon-rpc-client-logger-lifetime-issue
branch
from
77b1364 to
086f9aa
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation for #4818.