[osx] Decrease preferred subnet mask length to 22#4833
Merged
jimporter merged 1 commit intoavailability-zonesfrom Apr 20, 2026
Merged
[osx] Decrease preferred subnet mask length to 22#4833jimporter merged 1 commit intoavailability-zonesfrom
jimporter merged 1 commit intoavailability-zonesfrom
Conversation
sharder996
approved these changes
Apr 17, 2026
Collaborator
sharder996
left a comment
sharder996
left a comment
There was a problem hiding this comment.
Yup, don't see a problem with this. Should make Multipass a bit more durable.
sharder996
requested changes
Apr 17, 2026
Collaborator
sharder996
left a comment
sharder996
left a comment
There was a problem hiding this comment.
Wait, there might be an issue. Got [2026-04-17T15:00:43.533] [error] [daemon] Caught an unhandled exception: invalid IP octet
This gives us more options to pick a working subnet, on the off chance that 192.168.252.0/24 is in-use.
jimporter
force-pushed
the
az-macos-subnet-mask
branch
from
76ea2ce to
e06ad52
Compare
jimporter
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## availability-zones #4833 +/- ##
======================================================
+ Coverage 87.69% 87.71% +0.03%
======================================================
Files 269 269
Lines 14636 14644 +8
======================================================
+ Hits 12834 12844 +10
+ Misses 1802 1800 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sharder996
approved these changes
Apr 20, 2026
Collaborator
sharder996
left a comment
sharder996
left a comment
There was a problem hiding this comment.
Ok, should be good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This gives us more options to pick a working subnet, on the off chance that 192.168.252.0/24 is in-use.
Checklist