Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/hyperv-api-backend-virtual-machine #4722 +/- ##
===========================================================================
Coverage 87.78% 87.78%
===========================================================================
Files 269 269
Lines 14573 14573
===========================================================================
Hits 12791 12791
Misses 1782 1782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xmkg
force-pushed
the
feature/hyperv-api-backend-virtual-machine
branch
from
921de08 to
e32e80a
Compare
xmkg
force-pushed
the
feature/hyperv-api-snapshots
branch
from
cb9b720 to
5c39aaa
Compare
xmkg
force-pushed
the
feature/hyperv-api-backend-virtual-machine
branch
2 times, most recently
from
4642fa0 to
3de21e5
Compare
xmkg
force-pushed
the
feature/hyperv-api-snapshots
branch
4 times, most recently
from
23064f4 to
7ca5e4f
Compare
xmkg
force-pushed
the
feature/hyperv-api-backend-virtual-machine
branch
from
6fcebbe to
fd2109f
Compare
xmkg
force-pushed
the
feature/hyperv-api-backend-virtual-machine
branch
from
7c75400 to
54ab42e
Compare
xmkg
force-pushed
the
feature/hyperv-api-snapshots
branch
from
7ca5e4f to
53c7be4
Compare
xmkg
force-pushed
the
feature/hyperv-api-backend-virtual-machine
branch
2 times, most recently
from
af7732b to
ec5aa2c
Compare
xmkg
force-pushed
the
feature/hyperv-api-snapshots
branch
2 times, most recently
from
6904553 to
62a4f25
Compare
xmkg
force-pushed
the
feature/hyperv-api-snapshots
branch
4 times, most recently
from
2a19e82 to
118790b
Compare
This reverts commit 421d99c.
The old merge behavior was backward, meaning the deleted disk would be merged to its parent. The new implementation now correctly merges forward -- each child disk would have the deleted disk's contents. Added integration tests for the snapshot erase.
xmkg
force-pushed
the
feature/hyperv-api-snapshots
branch
from
118790b to
cf2a75a
Compare
Base automatically changed from
feature/hyperv-api-backend-virtual-machine
to
main
May 5, 2026 20:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement forward-merge on erase behavior for the virtdisk snapshot feature.