fix(cli): gracefully handle non-TTY stdin in raw_input_char - #641
Open
Deeven-Seru wants to merge 3 commits into
Open
fix(cli): gracefully handle non-TTY stdin in raw_input_char#641Deeven-Seru wants to merge 3 commits into
Deeven-Seru wants to merge 3 commits into
Conversation
When apport-cli is run in an environment where stdin is not a terminal (e.g., redirected or background jobs), it crashed with an unhandled termios.error when trying to pause for input. This patch checks os.isatty() and reads normally if not a TTY.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 84.47% 84.50% +0.03%
==========================================
Files 106 106
Lines 21053 21083 +30
Branches 3223 3233 +10
==========================================
+ Hits 17784 17816 +32
+ Misses 2792 2788 -4
- Partials 477 479 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When apport-cli is run in an environment where stdin is not a terminal (e.g., redirected input or background jobs), it crashed with an unhandled termios.error when trying to pause for input. This patch checks os.isatty() and reads normally if not a TTY.