Skip to content

report: get value for VmCore only once #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdrung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

report: get value for VmCore only once #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apport/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,13 +971,14 @@ def add_kernel_crash_info(self) -> bool:

This needs a VmCore in the Report.
"""
if "VmCore" not in self:
vm_core = self.get("VmCore")
if vm_core is None:
return False
with tempfile.NamedTemporaryFile(prefix="apport_vmcore_") as core:
if hasattr(self["VmCore"], "write"):
self["VmCore"].write(core)
if hasattr(vm_core, "write"):
vm_core.write(core)
else:
core.write(self["VmCore"])
core.write(vm_core)
core.flush()

kver = self["Uname"].split()[1]
Expand Down
Loading