Conversation
#6136 dropped the report-site pipeline, but its last deploy is still live on gh-pages — so https://caffeinelabs.github.io/motoko/ serves a page frozen at 2026-05-21, and every link on it 404s: the index was generated by `tree -H . --fromfile`, which emits `../`-prefixed hrefs. Served from `/motoko/`, `../coverage/` resolves outside the Pages prefix (verified: 404). Subdirectories without an `index.html` 404 too, since Pages generates no directory listings. Restore the pipeline for the coverage report only (the `base-doc` and `docs` entries of the old site are gone) with a hand-written landing page whose single link is relative, so it works at whatever prefix the site is served from. No `tree` dependency any more. `report-site` sits in `packages` rather than `common-constituents`, because the latter feeds the `*-systems-go` aggregates and would drag the instrumented coverage build into every test job. Verified: the derivation builds against a stub coverage input and emits `href="./coverage/"`; `nix eval .#report-site.name` resolves; actionlint reports nothing on the new job. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Contributor
Cursor AI review👍 APPROVE — looks safe to merge
VerdictDecision: APPROVE Generated for commit ce6e061 |
Contributor
|
This pull request has had no activity for 30 days and has been marked as stale. It will be closed in 14 days unless there is new activity. Comment or push to keep it open, or add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6136 dropped the report-site pipeline, but its final deploy is still live: https://caffeinelabs.github.io/motoko/ serves a page frozen at 2026-05-21 whose every link 404s. Two independent causes, both verified:
tree -H . --fromfile, which emits../-prefixed hrefs — served from/motoko/,../coverage/resolves tocaffeinelabs.github.io/coverage/, outside the Pages prefix (404). Reproduced locally with the exact command.index.htmland never generates listings, so e.g./coverage/ir_passes/404s while/coverage/ir_passes/tailcall.ml.htmlis fine.This restores the pipeline for coverage only — the old site's
base-docanddocsentries are gone — with a hand-written landing page whose single link is relative, so it works at any prefix. Notreedependency.report-sitedeliberately lives inpackages, notcommon-constituents: the latter feeds the*-systems-goaggregates and would pull the instrumented coverage build into every test job.Verified locally: the derivation builds against a stub coverage input and emits
href="./coverage/";nix eval .#report-site.nameresolves;actionlintreports nothing on the new job (the findings it does report are pre-existing, in other jobs).Note the
reportsjob only runs on push tomaster, so it cannot exercise itself on this PR — the first real deploy happens on merge. Existing/coverage/...URLs keep working, since the report stays undercoverage/.No Changelog entry: this is CI/infra, with no user-visible compiler change.